kezhenxu94 commented on code in PR #10876:
URL: https://github.com/apache/skywalking/pull/10876#discussion_r1214069049
##########
pom.xml:
##########
@@ -522,6 +523,17 @@
</sourcepath>
</configuration>
</plugin>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>${maven-compiler-plugin.version}</version>
+ <configuration>
+ <source>11</source>
+ <target>11</target>
+ <compilerVersion>11</compilerVersion>
Review Comment:
@weihubeats read this
https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#source
and
https://maven.apache.org/plugins/maven-compiler-plugin/compile-mojo.html#target
> <source>
The -source argument for the Java compiler.
Type: java.lang.String
Required: No
User Property: maven.compiler.source // <<< 👈 this one
Default: 1.8
the equivalent property is `maven.compiler.source` and we already defined it
in the `<properties>` section, so I mean we don't need to set
`<source>/<target>/<compilerVersion>` here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
