weihubeats commented on code in PR #10876:
URL: https://github.com/apache/skywalking/pull/10876#discussion_r1214148360
##########
pom.xml:
##########
@@ -522,6 +523,17 @@
</sourcepath>
</configuration>
</plugin>
+ <plugin>
+ <artifactId>maven-compiler-plugin</artifactId>
+ <version>${maven-compiler-plugin.version}</version>
+ <configuration>
+ <source>11</source>
+ <target>11</target>
+ <compilerVersion>11</compilerVersion>
Review Comment:
Because using `${maven.compiler.source}` he will not read the version
defined in the project, but will still read the jdk version in maven
setttings.xml, so we need to define a different variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
