xu1009 commented on code in PR #590:
URL: https://github.com/apache/skywalking-java/pull/590#discussion_r1283399353


##########
test/plugin/scenarios/jetty-scenario/jettyclient-scenario/src/main/java/org/apache/skywalking/apm/testcase/jettyclient/controller/CaseController.java:
##########
@@ -45,6 +46,8 @@ public void init() throws Exception {
     @ResponseBody
     public String jettyClientScenario() throws Exception {
         client.newRequest("http://"; + jettyServerHost + 
":18080/jettyserver-case/case/receiveContext-0").send();
+        Response.CompleteListener listener = result -> { };

Review Comment:
   if you do something in listener such as query mysql, the trace context can 
not been got because your plugin just put span in request attribute



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to