[skywalking-grafana-plugins] branch main updated: fix: Incorrect metric configuration (#26)

[qiuxiafan]

This is an automated email from the ASF dual-hosted git repository.

qiuxiafan pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/skywalking-grafana-plugins.git


The following commit(s) were added to refs/heads/main by this push:
     new 932101a  fix: Incorrect metric configuration (#26)
932101a is described below

commit 932101aec4c80d30628192f68295e283c02fe840
Author: Fine0830 <fanxue0...@gmail.com>
AuthorDate: Fri Aug 25 18:17:21 2023 +0800

    fix: Incorrect metric configuration (#26)
---
 src/datasource.ts | 27 ++++++++++++++-------------
 1 file changed, 14 insertions(+), 13 deletions(-)

diff --git a/src/datasource.ts b/src/datasource.ts
index e03310a..ea621e9 100644
--- a/src/datasource.ts
+++ b/src/datasource.ts
@@ -221,19 +221,19 @@ export class DataSource extends DataSourceApi<MyQuery, 
MyDataSourceOptions> {
     const mainStatField = { name: NodeGraphDataFrameFieldNames.mainStat, type: 
FieldType.number, values: new ArrayVector(), config: {}};
     const secondaryStatField = { name: 
NodeGraphDataFrameFieldNames.secondaryStat, type: FieldType.number, values: new 
ArrayVector(), config: {}};
     const detailsFields: any = [];
-    for (const [index, k] of Object.keys(metrics.data).entries()) {
-      const c = metrics.config.find((d: MetricData) => d.name === k) || {};
+    for (let i = 0; i < metrics.config.length; i++) {
+      const c = metrics.config[i];
       const config = {displayName: c.label, unit: c.unit};
-      if (index === 0) {
+      if (i === 0) {
         mainStatField.config = config;
-      } else if (index === 1) {
+      } else if (i === 1) {
         secondaryStatField.config = config;
       } else {
         detailsFields.push({
-          name: `${NodeGraphDataFrameFieldNames.detail}${k}`,
+          name: `${NodeGraphDataFrameFieldNames.detail}${c.name}`,
           type: FieldType.number,
           values: new ArrayVector(),
-          config: {displayName: `${c.label || k } ${c.unit || ''}`}
+          config: {displayName: `${c.label || c.name } ${c.unit || ''}`}
         });
       }
     }
@@ -267,20 +267,21 @@ export class DataSource extends DataSourceApi<MyQuery, 
MyDataSourceOptions> {
     const mainStatField = { name: NodeGraphDataFrameFieldNames.mainStat, type: 
FieldType.number, values: new ArrayVector(), config: {}};
     const secondaryStatField = { name: 
NodeGraphDataFrameFieldNames.secondaryStat, type: FieldType.number, values: new 
ArrayVector(), config: {}};
     const detailsFields: any = [];
-    for (const [index, k] of Object.keys(metrics.data).entries()) {
-      const c = metrics.config.find((d: MetricData) => d.name === k) || {};
-      const config = {displayName: c.label, unit: c.unit};
-      if (index === 0) {
+
+    for (let i = 0; i < metrics.config.length; i++) {
+      const k = metrics.config[i];
+      const config = {displayName: k.label, unit: k.unit};
+      if (i === 0) {
         mainStatField.config = config;
       }
-      else if (index === 1) {
+      else if (i === 1) {
         secondaryStatField.config = config;
       } else {
         detailsFields.push({
-          name: `${NodeGraphDataFrameFieldNames.detail}${k}`,
+          name: `${NodeGraphDataFrameFieldNames.detail}${k.name}`,
           type: FieldType.number,
           values: new ArrayVector(),
-          config: {displayName: `${c.label || k } ${c.unit || ''}`}
+          config: {displayName: `${k.label || k.name } ${k.unit || ''}`}
         });
       }
     }