wankai123 commented on code in PR #11336:
URL: https://github.com/apache/skywalking/pull/11336#discussion_r1327342622
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/RunningRule.java:
##########
@@ -198,8 +198,13 @@ public void moveTo(LocalDateTime targetTime) {
*/
public List<AlarmMessage> check() {
List<AlarmMessage> alarmMessageList = new ArrayList<>(30);
-
+ List<AlarmEntity> alarmEntityList = new ArrayList<>();
+ LocalDateTime currentTime = LocalDateTime.now();
windows.forEach((alarmEntity, window) -> {
Review Comment:
I think you could remove all `null value` windows before checkAlarm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
