This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 77736c5  okhttp OnFailureInterceptor should log exception info (#3381)
77736c5 is described below

commit 77736c5e7da41f117dee577345076411df61fba4
Author: qxo <49526...@qq.com>
AuthorDate: Fri Aug 30 22:39:28 2019 +0800

    okhttp OnFailureInterceptor should log exception info (#3381)
---
 .../apache/skywalking/apm/plugin/okhttp/v3/OnFailureInterceptor.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/OnFailureInterceptor.java
 
b/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/OnFailureInterceptor.java
index 9b6d357..4515723 100644
--- 
a/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/OnFailureInterceptor.java
+++ 
b/apm-sniffer/apm-sdk-plugin/okhttp-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/okhttp/v3/OnFailureInterceptor.java
@@ -28,7 +28,7 @@ public class OnFailureInterceptor implements 
InstanceMethodsAroundInterceptor {
     @Override
     public void beforeMethod(EnhancedInstance objInst, Method method, Object[] 
allArguments, Class<?>[] argumentsTypes,
         MethodInterceptResult result) throws Throwable {
-        ContextManager.activeSpan().errorOccurred();
+        
ContextManager.activeSpan().errorOccurred().log((Throwable)allArguments[1]);
     }
 
     @Override

Reply via email to