wu-sheng commented on code in PR #124:
URL: https://github.com/apache/skywalking-go/pull/124#discussion_r1363055254
##########
plugins/fasthttp/client/client_intercepter_test.go:
##########
@@ -63,9 +63,9 @@ func TestClientInvoke(t *testing.T) {
spans := core.GetReportedSpans()
assert.NotNil(t, spans, "spans should not be nil")
assert.Equal(t, 1, len(spans), "spans length should be 1")
- assert.Equal(t, "GET:http://localhost/";, spans[0].OperationName(),
"operation name should be GET:/")
+ assert.Equal(t, "GET:http://localhost/";, spans[0].OperationName(),
"operation name should be GET:http://localhost/";)
assert.Equal(t, "Http", spans[0].SpanLayer().String(), "SpanLayer
should be Http")
- assert.Equal(t, int32(5019), spans[0].ComponentID(), "ComponentID
should be 5014")
+ assert.Equal(t, int32(5019), spans[0].ComponentID(), "ComponentID
should be 5019")
Review Comment:
Otherwise, others may have registered your ID before your submission.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
