wu-sheng commented on code in PR #644:
URL: https://github.com/apache/skywalking-java/pull/644#discussion_r1379609290
##########
apm-sniffer/apm-sdk-plugin/jdbc-commons/src/main/java/org/apache/skywalking/apm/plugin/jdbc/connectionurl/parser/ImpalaJdbcURLParser.java:
##########
@@ -99,7 +102,7 @@ public ConnectionInfo parse() {
} else {
String[] hostAndPort = hostSegment[0].split(":");
if (hostAndPort.length != 1) {
- return new ConnectionInfo(component, DB_TYPE, hostAndPort[0],
Integer.valueOf(hostAndPort[1]), fetchDatabaseNameFromURL(location
+ return new ConnectionInfo(component, DB_TYPE, hostAndPort[0],
Integer.parseInt(hostAndPort[1]), fetchDatabaseNameFromURL(location
Review Comment:
Could you explain why change this method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
