dmsolr commented on a change in pull request #3390: MOD: Modify compatibility
of kafka plugin and expand operationName
URL: https://github.com/apache/skywalking/pull/3390#discussion_r319832953
##########
File path:
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaProducerInstrumentation.java
##########
@@ -46,22 +46,35 @@
public static final String INTERCEPTOR_CLASS =
"org.apache.skywalking.apm.plugin.kafka.KafkaProducerInterceptor";
public static final String ENHANCE_CLASS =
"org.apache.kafka.clients.producer.KafkaProducer";
public static final String ENHANCE_METHOD = "doSend";
- public static final String CONSTRUCTOR_INTERCEPTOR_CLASS =
"org.apache.skywalking.apm.plugin.kafka.ProducerConstructorInterceptor";
- public static final String CONSTRUCTOR_INTERCEPTOR_FLAG =
"org.apache.kafka.clients.producer.ProducerConfig";
- public static final String METHOD_FLAG =
"org.apache.kafka.clients.producer.Callback";
+ public static final String CONSTRUCTOR_INTERCEPTOR_CLASS1 =
"org.apache.skywalking.apm.plugin.kafka.ProducerConstructorInterceptor";
Review comment:
I'm not sure if I can divide it into two instrumentations to do it through
witness class. Because it dose not look graceful enough. Coud you try it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
