lujiajing1126 commented on code in PR #150: URL: https://github.com/apache/skywalking-go/pull/150#discussion_r1393778468
########## tools/go-agent/instrument/plugins/instrument.go: ########## @@ -107,9 +108,8 @@ func (i *Instrument) CouldHandle(opts *api.CompileOptions) bool { // check the version of the framework could handler version, err := i.tryToFindThePluginVersion(opts, ins) if err != nil { - // Local package (e.g. replaced toolkit) does not have version. - // So when the version is not detected, we should not skip it. - logrus.Warnf("the plugin %s %s", ins.Name(), err) + logrus.Warnf("ignore the plugin %s, because %s", ins.Name(), err) + continue Review Comment: > I remember this is used to handle the check for missing version information when `replacing` in `go.mod`, @Alipebt could you help to re-check? I found the solution is not correct. Let me find another way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org