mrproliu commented on code in PR #11731:
URL: https://github.com/apache/skywalking/pull/11731#discussion_r1443947707
##########
oap-server/server-storage-plugin/storage-elasticsearch-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/elasticsearch/base/StorageEsInstaller.java:
##########
@@ -308,7 +308,8 @@ protected Mappings createMapping(Model model) {
Map<String, Object> properties = new HashMap<>();
Mappings.Source source = new Mappings.Source();
for (ModelColumn columnDefine : model.getColumns()) {
- final String type =
columnTypeEsMapping.transform(columnDefine.getType(),
columnDefine.getGenericType(), columnDefine.getElasticSearchExtension());
+ final String type =
columnTypeEsMapping.transform(columnDefine.getType(),
columnDefine.getGenericType(), columnDefine.getLength(),
+ columnDefine.getElasticSearchExtension());
Review Comment:
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
