wu-sheng commented on PR #11892: URL: https://github.com/apache/skywalking/pull/11892#issuecomment-1952628529
This change should be applied for certain use case, rather than making all YAML files adopting this change. And the max length should not be hard coded, it should be configurable. For example, if you are talking about alerting case, we should make alerting file reader to accept a configurable size as a parameter. Your current change is too reckless, and could cause OOM easily for loading a wrong file or malicious file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
