wu-sheng commented on PR #107: URL: https://github.com/apache/skywalking-php/pull/107#issuecomment-1955728454
> > > $spanId should not be for the entire request, right? > > > > > > It is not. It is variable according to span creation and stop status. > > I would like to implement $spanId in the future (if there is user demand) If that is the case, please remove segmentId as well, that is useless without span ID. Both IDs lock the specific span. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
