Sylvie-Wxr commented on code in PR #397:
URL:
https://github.com/apache/skywalking-banyandb/pull/397#discussion_r1513662402
##########
ui/src/components/Read/index.vue:
##########
@@ -347,27 +344,25 @@ function handleCodeData() {
getTableData()
}
function autoRefreshTimeRange() {
- if (isDatePicker.value) {
Review Comment:
Based on these 4 cases, I am unsure why do we need a boolean flag,
autoRefreshTimeRange() is only called after the user click "🔍".
“isDatePicker” is set to true only after the user manually selects a time
range.
“isDatePicker” is set to false after the user clicks on the code.
So, after my changes, the logic is like this:
### the use did not select anything, or "last 15 minutes" is selected.
If user click "🔍" , autoRefreshTimeRange() is triggered, both the start and
end dates will be updated to last 15 minutes of current time.
If user click "↻", the dates remain unchanged.
### A fixed time range is selected (last week, last month, last 3 months)
If user click "🔍" , autoRefreshTimeRange() is triggered, both the start and
end dates will be updated to the last selected time range of current time.
If user click "↻", the dates remain unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
