Superskyyy commented on code in PR #12030:
URL: https://github.com/apache/skywalking/pull/12030#discussion_r1527467336


##########
apm-webapp/src/main/java/org/apache/skywalking/oap/server/webapp/ApplicationStartUp.java:
##########
@@ -79,5 +84,9 @@ public static void main(String[] args) throws Exception {
             .build()
             .start()
             .join();
+
+        log.info(startedMarker, "SkyWalking booster UI is now running. " +
+            "OAP services at {} and booster UI at http://localhost:{}";,
+            String.join(", ", oapServices), port);

Review Comment:
   capitalize Booster



##########
changes/README.md:
##########
@@ -1 +1,9 @@
-## Changes are moved to [here](../docs/en/changes/)
+- Update log4j2.xml configurations in both apm-webapp and dist-material.
+
+- Add marker logging in ApplicationStartUp.java within apm-webapp. 
+
+- Change the GRPCServer.java logging in the 
oap-server/server-library/library-server to marker logging.
+
+- Fix console starts oapService.sh and webappService.sh scripts the startup 
message is undisplayed. 
+
+- Fix startup.sh starts oapService.sh and webappService.sh on the back-end, 
the startup message is displayed on the console.

Review Comment:
   And too verbose



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to