wu-sheng commented on code in PR #178:
URL: https://github.com/apache/skywalking-go/pull/178#discussion_r1531659046


##########
plugins/gin/intercepter.go:
##########
@@ -70,3 +77,26 @@ func isFirstHandle(c interface{}) bool {
        }
        return true
 }
+
+func collectHttpHeaders(span tracing.Span, requestHeaders http.Header) {
+       if len(runtimeConfig.CollectHttpHeaders) == 0 {

Review Comment:
   You should update the gin plugin test to verify this feature.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to