OrezzerO commented on code in PR #675: URL: https://github.com/apache/skywalking-java/pull/675#discussion_r1535104439
########## apm-sniffer/apm-sdk-plugin/sofarpc-plugin/src/main/java/org/apache/skywalking/apm/plugin/sofarpc/SofaBoltCallbackConstructInterceptor.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.apm.plugin.sofarpc; + +import org.apache.skywalking.apm.agent.core.context.ContextManager; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.EnhancedInstance; +import org.apache.skywalking.apm.agent.core.plugin.interceptor.enhance.InstanceConstructorInterceptor; + +public class SofaBoltCallbackConstructInterceptor implements InstanceConstructorInterceptor { + @Override + public void onConstruct(EnhancedInstance objInst, Object[] allArguments) { + if (ContextManager.isActive()) { + objInst.setSkyWalkingDynamicField(ContextManager.capture()); Review Comment: In the context of SOFARPC, InvokeCallback is a wrapper. Users directly use the SofaResponseCallback class. Each SOFARPC callback request corresponds uniquely to an InvokeCallback. However, in the context of SOFA BOLT (BOLT being a wrapper for Netty which SOFARPC relies on), InvokeCallback may be reused. It's a good idea to create a plugin level wrapper, but I am afraid I will introduce an error because of cannot dealing with classloader correctly. I plan to create a class `InvokeCallbackWrapper` in plugin code. How to make it loaded by business classloader? ```java public class InvokeCallbackWrapper implements InvokeCallback { private ContextSnapshot contextSnapshot; private InvokeCallback invokeCallback; public InvokeCallbackWrapper(InvokeCallback invokeCallback) { this.contextSnapshot = ContextManager.capture(); this.invokeCallback = invokeCallback; } @Override public void onResponse(final Object o) { ContextManager.createLocalSpan("Thread/" + invokeCallback.getClass().getName() + "/onResponse"); if (contextSnapshot != null) { ContextManager.continued(contextSnapshot); } try { invokeCallback.onResponse(o); } catch (Throwable t) { ContextManager.activeSpan().log(t); throw t; } finally { ContextManager.stopSpan(); contextSnapshot = null; } } @Override public void onException(final Throwable throwable) { ContextManager.createLocalSpan("Thread/" + invokeCallback.getClass().getName() + "/onException"); if (contextSnapshot != null) { ContextManager.continued(contextSnapshot); } if (throwable != null) { AbstractSpan abstractSpan = ContextManager.activeSpan(); if (abstractSpan != null) { abstractSpan.log(throwable); } } try { invokeCallback.onException(throwable); } catch (Throwable t) { ContextManager.activeSpan().log(t); throw t; } finally { ContextManager.stopSpan(); contextSnapshot = null; } } @Override public Executor getExecutor() { return invokeCallback.getExecutor(); } } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
