ZEALi opened a new pull request, #336: URL: https://github.com/apache/skywalking-python/pull/336
In some use cases, `pymysql.install_as_MySQLdb()` will be used to initialize a 'fake' MySQLdb module, which is actually mapped to pymysql module. Unfortunately, sw_mysqlclient plugin changes the data type of `connection.db` from `bytes` into `str`, which is regard as `bytes` in sw_pymysql plugin. That will cause the `AttributeError: 'str' object has no attribute 'decode'` exception in sw_pymysql.py line 45. So if the `MySQLdb` module is only a pointer to `pymysql`, we should just raise ImportError instead of installation for sw_mysqlclient plugin. - [ ] Update the [`CHANGELOG.md`](https://github.com/apache/skywalking-python/blob/master/CHANGELOG.md). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
