wu-sheng commented on code in PR #693:
URL: https://github.com/apache/skywalking-java/pull/693#discussion_r1609131914
##########
apm-sniffer/apm-sdk-plugin/redisson-3.x-plugin/src/main/java/org/apache/skywalking/apm/plugin/redisson/v3/RedissonPluginConfig.java:
##########
@@ -40,6 +40,14 @@ public static class Redisson {
* Set a negative number to save specified length of parameter
string to the tag.
*/
public static int REDIS_PARAMETER_MAX_LENGTH = 128;
+ /**
+ * If set to false, the PING command would be collected.
+ */
+ public static boolean PING_IGNORED = true;
Review Comment:
I think you should keep the configuration style consistent. Now, one
configuration is with `show...`, the other is `ignored...`. I think the style
should use `show_xxx` and they should be aligned.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
