hanahmily commented on code in PR #453:
URL:
https://github.com/apache/skywalking-banyandb/pull/453#discussion_r1619913826
##########
banyand/observability/service.go:
##########
@@ -52,19 +71,41 @@ type metricService struct {
scheduler *timestamp.Scheduler
metadata metadata.Repo
listenAddr string
+ modes []string
mutex sync.Mutex
}
func (p *metricService) FlagSet() *run.FlagSet {
flagSet := run.NewFlagSet("observability")
flagSet.StringVar(&p.listenAddr, "observability-listener-addr",
":2121", "listen addr for observability")
+ flagSet.StringArrayVar(&p.modes, "observability-modes",
[]string{"prometheus"}, "modes for observability")
return flagSet
}
func (p *metricService) Validate() error {
if p.listenAddr == "" {
return errNoAddr
}
+ set := make(map[string]bool)
Review Comment:
```suggestion
set := make(map[string]struct{})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
