wu-sheng commented on code in PR #12321:
URL: https://github.com/apache/skywalking/pull/12321#discussion_r1634653708


##########
docs/en/setup/backend/configuration-vocabulary.md:
##########
@@ -38,7 +38,7 @@ The Configuration Vocabulary lists all available 
configurations provided by `app
 | -                       | -             | autocompleteTagValuesQueryMaxSize  
                                                                                
                                                      | The max size of tags 
values for autocomplete select.                                                 
                                                                                
                                                                                
                                                                                
                                                                                
                                      | 
SW_AUTOCOMPLETE_TAG_VALUES_QUERY_MAX_SIZE             | 100                     
                                                                     |
 | -                       | -             | gRPCThreadPoolSize                 
                                                                                
                                                      | Pool size of gRPC 
server.                                                                         
                                                                                
                                                                                
                                                                                
                                                                                
                                         | SW_CORE_GRPC_THREAD_POOL_SIZE        
                 | Default to gRPC's implementation, which is a cached thread 
pool that can grow infinitely.    |
 | -                       | -             | maxConcurrentCallsPerConnection    
                                                                                
                                                      | The maximum number of 
concurrent calls permitted for each incoming connection. Defaults to no limit.  
                                                                                
                                                                                
                                                                                
                                                                                
                                     | SW_CORE_GRPC_MAX_CONCURRENT_CALL         
             | -                                                                
                            |
-| -                       | -             | maxMessageSize                     
                                                                                
                                                      | Sets the maximum 
message size allowed to be received on the server. Empty means 4 MiB.           
                                                                                
                                                                                
                                                                                
                                                                                
                                          | SW_CORE_GRPC_MAX_MESSAGE_SIZE       
                  | 4M(based on Netty)                                          
                                 |
+| -                       | -             | maxMessageSize                     
                                                                                
                                                      | Sets the maximum 
message size allowed to be received on the server. Empty means 4 MiB.           
                                                                                
                                                                                
                                                                                
                                                                                
                                          | SW_CORE_GRPC_MAX_MESSAGE_SIZE       
                  | 52428800 (50MB)                                             
                                 |

Review Comment:
   Yes, we noticed this on demo deployment.
   We increased application.yml values, so yes, default values changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to