wu-sheng commented on code in PR #187: URL: https://github.com/apache/skywalking-go/pull/187#discussion_r1644100435
########## CHANGES.md: ########## @@ -13,6 +13,10 @@ Release Notes. * Support http headers collection for Gin * Support higher versions of grpc. +### Bug Fixes +* Fix panic error when root span finished. +* Update the peer address is not required when creating exit span. Review Comment: If it can't be obtained, we should consider this is a plugin bug. OAP failove mechanism is just for avoiding errors, but logically it is still wrong. This causes(for exit span) 1. No virtual service(DB, MQ, etcd.) 1. Trace broken at server side, as the trace context in sw8 header is wrong. 1. Topology broken in case <2> In theory, when peer is absent, we should create an exit span. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
