shalk commented on code in PR #12362:
URL: https://github.com/apache/skywalking/pull/12362#discussion_r1650913958


##########
oap-server/server-cluster-plugin/cluster-nacos-plugin/src/test/java/org/apache/skywalking/oap/server/cluster/plugin/nacos/ClusterModuleNacosProviderFunctionalIT.java:
##########
@@ -82,6 +81,13 @@ public void before() {
         Whitebox.setInternalState(telemetryModule, "loadedProvider", 
telemetryProvider);
         
Mockito.when(moduleManager.find(TelemetryModule.NAME)).thenReturn(telemetryModule);
         nacosAddress = container.getHost() + ":" + 
container.getMappedPort(8848);
+        Integer nacosPortOffset = container.getMappedPort(9848) - 
container.getMappedPort(8848);
+        System.setProperty("nacos.server.grpc.port.offset", 
nacosPortOffset.toString());

Review Comment:
   Nacos 2.x  server have two port, 8848(http) and 9948(gRPC) by default. Nacos 
Client 's implement use 8848(http.port) + 1000(nacos.server.grpc.port.offset) 
as gRPC port. It works on virtual machine.
    But the testContainer will not Mapport the port One-By-One. so i need to 
configure nacos.server.grpc.port.offset  
   
   Doc ref 
:https://nacos.io/docs/next/manual/user/java-sdk/properties/#24-%E8%BF%9E%E6%8E%A5%E7%9B%B8%E5%85%B3



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to