darkness-2nd commented on code in PR #707:
URL: https://github.com/apache/skywalking-java/pull/707#discussion_r1690854260
##########
apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/define/KafkaConsumerInstrumentation.java:
##########
@@ -63,103 +63,103 @@ public class KafkaConsumerInstrumentation extends
AbstractKafkaInstrumentation {
@Override
public ConstructorInterceptPoint[] getConstructorsInterceptPoints() {
return new ConstructorInterceptPoint[] {
- new ConstructorInterceptPoint() {
- @Override
- public ElementMatcher<MethodDescription>
getConstructorMatcher() {
- return takesArgumentWithType(0,
CONSTRUCTOR_INTERCEPT_TYPE);
- }
+ new ConstructorInterceptPoint() {
+ @Override
+ public ElementMatcher<MethodDescription>
getConstructorMatcher() {
+ return takesArgumentWithType(0,
CONSTRUCTOR_INTERCEPT_TYPE);
+ }
- @Override
- public String getConstructorInterceptor() {
- return CONSUMER_CONFIG_CONSTRUCTOR_INTERCEPTOR_CLASS;
- }
- },
- new ConstructorInterceptPoint() {
- @Override
- public ElementMatcher<MethodDescription>
getConstructorMatcher() {
- return takesArgumentWithType(0,
CONSTRUCTOR_INTERCEPT_MAP_TYPE);
- }
-
- @Override
- public String getConstructorInterceptor() {
- return MAP_CONSTRUCTOR_INTERCEPTOR_CLASS;
- }
- },
+ @Override
+ public String getConstructorInterceptor() {
+ return CONSUMER_CONFIG_CONSTRUCTOR_INTERCEPTOR_CLASS;
+ }
+ },
+ new ConstructorInterceptPoint() {
+ @Override
+ public ElementMatcher<MethodDescription>
getConstructorMatcher() {
+ return takesArgumentWithType(0,
CONSTRUCTOR_INTERCEPT_MAP_TYPE);
+ }
+
+ @Override
+ public String getConstructorInterceptor() {
+ return MAP_CONSTRUCTOR_INTERCEPTOR_CLASS;
+ }
+ },
Review Comment:
> > I have already recerted it, this class dosen't change, I have already
rollback it to the original version
>
> No, you didn't. Change is still there.
Those changes are compare to the changes which are not correct I commit
before...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
