wuguangkuo commented on a change in pull request #3475: Add feature to control
the maximum agent log files
URL: https://github.com/apache/skywalking/pull/3475#discussion_r325492827
##########
File path:
apm-sniffer/apm-agent-core/src/main/java/org/apache/skywalking/apm/agent/core/logging/core/FileWriter.java
##########
@@ -134,6 +136,41 @@ public Object call() throws Exception {
return null;
}
});
+
+ if (Config.Logging.MAX_HISTORY_FILES > 0) {
Review comment:
no, this will be execute every time when log file rollover happen
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
