kezhenxu94 commented on code in PR #12777:
URL: https://github.com/apache/skywalking/pull/12777#discussion_r1846166687
##########
oap-server/server-starter/src/main/resources/application.yml:
##########
@@ -342,6 +342,11 @@ receiver-async-profiler:
default:
# Used to manage the maximum size of the jfr file that can be received,
the unit is Byte, default is 30M
jfrMaxSize: ${SW_RECEIVER_ASYNC_PROFILER_JFR_MAX_SIZE:31457280}
+ # Used to determine whether to receive jfr in memory file or physical file
mode
+ # Memory files have fewer local file system limitations, so they are by
default. But it costs more memory.
+ # When users need to parse large JFR files(rare case), they could switch
to file mode.
+ # For details, please refer to the comments of class
AsyncProfilerModuleConfig
+ memoryParserEnabled:
${SW_RECEIVER_ASYNC_PROFILER_MEMORY_PARSER_ENABLED:true}
Review Comment:
Please add this new config to
https://github.com/apache/skywalking/blob/master/docs/en/setup/backend/configuration-vocabulary.md
##########
oap-server/server-starter/src/main/resources/application.yml:
##########
@@ -342,6 +342,11 @@ receiver-async-profiler:
default:
# Used to manage the maximum size of the jfr file that can be received,
the unit is Byte, default is 30M
jfrMaxSize: ${SW_RECEIVER_ASYNC_PROFILER_JFR_MAX_SIZE:31457280}
+ # Used to determine whether to receive jfr in memory file or physical file
mode
+ # Memory files have fewer local file system limitations, so they are by
default. But it costs more memory.
+ # When users need to parse large JFR files(rare case), they could switch
to file mode.
+ # For details, please refer to the comments of class
AsyncProfilerModuleConfig
Review Comment:
Since memory mode has fewer limitations than local mode, and local file mode
is for saving memory when the JFR file is large, what about changing the config
to set the JFR file size threshold, for example when the file size is >= some
value then use local file otherwise we can safely use memory mode
##########
oap-server/server-starter/src/main/resources/application.yml:
##########
@@ -342,6 +342,11 @@ receiver-async-profiler:
default:
# Used to manage the maximum size of the jfr file that can be received,
the unit is Byte, default is 30M
jfrMaxSize: ${SW_RECEIVER_ASYNC_PROFILER_JFR_MAX_SIZE:31457280}
+ # Used to determine whether to receive jfr in memory file or physical file
mode
+ # Memory files have fewer local file system limitations, so they are by
default. But it costs more memory.
+ # When users need to parse large JFR files(rare case), they could switch
to file mode.
+ # For details, please refer to the comments of class
AsyncProfilerModuleConfig
Review Comment:
This is end-user oriented, prefer duplicating the comment here instead of
asking user to check the source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
