wu-sheng commented on code in PR #12959:
URL: https://github.com/apache/skywalking/pull/12959#discussion_r1912439584
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/BanyanDBStorageClient.java:
##########
@@ -70,6 +75,29 @@ public BanyanDBStorageClient(BanyanDBStorageConfig config) {
@Override
public void connect() throws Exception {
this.client.connect();
+ BanyandbCommon.APIVersion apiVersion;
+ try {
+ apiVersion = this.client.getAPIVersion();
+ } catch (BanyanDBException e) {
+ final Throwable cause = e.getCause();
+ if (cause instanceof StatusRuntimeException) {
+ final Status status = ((StatusRuntimeException)
cause).getStatus();
+ if (Status.Code.UNIMPLEMENTED.equals(status.getCode())) {
+ log.error("fail to get BanyanDB API version, server
version < 0.8 is not supported.");
+ }
Review Comment:
This is for versions before 0.8.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
