wu-sheng commented on a change in pull request #3476: Add pulsar apm plugin
URL: https://github.com/apache/skywalking/pull/3476#discussion_r326943383
##########
File path:
apm-sniffer/apm-sdk-plugin/pulsar-plugin/src/main/java/org/apache/skywalking/apm/plugin/pulsar/PulsarConsumerInterceptor.java
##########
@@ -54,12 +54,11 @@
@Override
public void beforeMethod(EnhancedInstance objInst, Method method, Object[]
allArguments, Class<?>[] argumentsTypes,
MethodInterceptResult result) throws Throwable {
- if (allArguments.length > 0 && allArguments[0] != null) {
+ if (allArguments[0] != null) {
ConsumerEnhanceRequiredInfo requiredInfo =
(ConsumerEnhanceRequiredInfo) objInst.getSkyWalkingDynamicField();
- requiredInfo.setStartTime(System.currentTimeMillis());
AbstractSpan activeSpan =
ContextManager.createEntrySpan(OPERATE_NAME_PREFIX +
requiredInfo.getTopic() + CONSUMER_OPERATE_NAME +
requiredInfo.getSubscriptionName(), null)
- .start(requiredInfo.getStartTime());
+ .start(System.currentTimeMillis());
Review comment:
`#createEntrySpan` has set start time automatically, you could find it in
source does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
