hanahmily commented on code in PR #681:
URL:
https://github.com/apache/skywalking-banyandb/pull/681#discussion_r2144390835
##########
bydbctl/internal/cmd/property_test.go:
##########
@@ -126,6 +126,20 @@ tags:
Expect(out).To(ContainSubstring("tagsNum: 2"))
})
+ It("update property", func() {
Review Comment:
More tests should be introduced:
### 1. Query: Select the latest version.
You should set up a cluster with different versions:
1. Create two test directories to save the same key with different versions.
You can use standalone to do it.
2. Start up two data nodes(setup.DataNode) on them
3. Start up a liaison node(setup.LiaisonNode) to connect the two data nodes.
4. Query the property through the liaison node to get the latest version.
### 2. Delete:
1. As the Query's first step. But you should delete one of the versions.
2. If the latest version is deleted, the query should return an empty result.
3. Else, the query should return a property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
