ButterBright commented on code in PR #703:
URL:
https://github.com/apache/skywalking-banyandb/pull/703#discussion_r2213751008
##########
banyand/stream/block.go:
##########
@@ -584,25 +584,28 @@ func (bc *blockCursor) loadData(tmpBlock *block) bool {
bc.elementIDs = append(bc.elementIDs,
tmpBlock.elementIDs[s:e+1]...)
}
- for i, projection := range bc.bm.tagProjection {
+ for _, cf := range tmpBlock.tagFamilies {
tf := tagFamily{
- name: projection.Family,
+ name: cf.name,
}
- for j, name := range projection.Names {
+ for i := range cf.tags {
Review Comment:
The tag filtering in loadData previously excluded indexed_only tags, which
had to be retrieved by iterating through the projection. After removing the
indexed_only field, we could align the implementation with how measures are
processed, improving consistency and readability.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
