wu-sheng commented on code in PR #13414:
URL: https://github.com/apache/skywalking/pull/13414#discussion_r2275036444
##########
oap-server/server-library/library-datacarrier-queue/src/main/java/org/apache/skywalking/oap/server/library/datacarrier/consumer/MultipleChannelsConsumer.java:
##########
@@ -33,11 +34,17 @@ public class MultipleChannelsConsumer extends Thread {
@SuppressWarnings("NonAtomicVolatileUpdate")
private volatile long size;
private final long consumeCycle;
+ // The flag to indicate whether the consumer thread should consume data.
+ @Setter
+ private volatile boolean consumeFlag = false;
+ // Whether the consumer thread should wait for notification to consume
data.
+ private boolean notifiable = false;
Review Comment:
```suggestion
// Consumer has two modes to drive consumption. 1. Polling mode. 2.
Singal-Driven mode.
private final boolean isSignalDrivenMode = false;
```
This should be immutable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
