lymboy commented on code in PR #235:
URL: https://github.com/apache/skywalking-go/pull/235#discussion_r2377511508
##########
tools/go-agent/instrument/logger/frameworks/logrus_adapt.go:
##########
@@ -22,18 +22,18 @@ import (
)
func UpdateLogrusLogger(l *logrus.Logger) {
- if l == nil {
- return
- }
-
- if LogTracingContextEnable {
- if _, wrapperd := l.Formatter.(*WrapFormat); !wrapperd {
- l.Formatter = Wrap(l.Formatter, LogTracingContextKey)
- }
- }
- if ChangeLogger != nil {
- ChangeLogger(NewLogrusAdapter(l))
- }
+ if l == nil {
+ return
+ }
+
+ if LogTracingContextEnable {
+ if _, wrapperd := l.Formatter.(*WrapFormat); !wrapperd {
+ l.Formatter = Wrap(l.Formatter, LogTracingContextKey)
+ }
+ }
+ if ChangeLogger != nil {
+ ChangeLogger(NewLogrusAdapter(l))
+ }
Review Comment:
Got it, thanks! I’m testing the workflow to meet the CI requirements. I’ll
create a new branch to avoid affecting this PR.
##########
.github/workflows/plugin-tests.yaml:
##########
@@ -21,7 +21,13 @@ concurrency:
cancel-in-progress: true
on:
+ push:
+ branches:
+ - '**'
pull_request:
+ branches:
+ - '**'
+# pull_request:
Review Comment:
Got it, thanks! I’m testing the workflow to meet the CI requirements. I’ll
create a new branch to avoid affecting this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
