Copilot commented on code in PR #13525:
URL: https://github.com/apache/skywalking/pull/13525#discussion_r2384876596
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/MetadataRegistry.java:
##########
@@ -238,6 +238,9 @@ public TraceModel registerTraceModel(Model model,
BanyanDBStorageConfig config)
if (columnStorageName.equals(Record.TIME_BUCKET)) {
continue;
}
+ if (!col.getBanyanDBExtension().shouldIndex()) {
Review Comment:
This check should be moved before the TIME_BUCKET check to avoid unnecessary
processing. If a column shouldn't be indexed, there's no need to check if it's
TIME_BUCKET.
```suggestion
if (!col.getBanyanDBExtension().shouldIndex()) {
continue;
}
if (columnStorageName.equals(Record.TIME_BUCKET)) {
```
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/storage/model/StorageModels.java:
##########
@@ -100,7 +100,7 @@ public Model add(Class<?> aClass, int scopeId, Storage
storage) throws StorageEx
String timestampColumn =
aClass.getAnnotation(BanyanDB.TimestampColumn.class).value();
if (StringUtil.isBlank(timestampColumn)) {
throw new IllegalStateException(
- "Model[trace." + storage.getModelName() + "] missing
defined @BanyanDB.TimestampColumn");
+ "Model[ " + storage.getModelName() + "] missing defined
@BanyanDB.TimestampColumn");
Review Comment:
There's an extra space after 'Model[' that creates inconsistent formatting
compared to line 112 which correctly uses 'Model[trace.' without the extra
space.
```suggestion
"Model[" + storage.getModelName() + "] missing defined
@BanyanDB.TimestampColumn");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
