Copilot commented on code in PR #13546:
URL: https://github.com/apache/skywalking/pull/13546#discussion_r2438734156


##########
test/e2e-v2/cases/profiling/ebpf/network/expected/metrics-has-http1-value-label.yml:
##########
@@ -62,6 +62,21 @@ results:
         owner: null
         traceid: null
       {{- end}}
+  - metric:
+      labels:
+        - key: p
+          value: "95"
+    values:
+      { { - contains .values } }
+      - id: { { notEmpty .id } }
+        value: { { .value } }
+        owner: null
+        traceid: null
+      - id: { { notEmpty .id } }
+        value: null
+        owner: null
+        traceid: null
+      { { - end } }

Review Comment:
   The Go template delimiters have extra spaces, breaking the expected result 
template parsing. Replace them with the correct delimiters, e.g., use "{{- 
contains .values }}", "- id: {{ notEmpty .id }}", "value: {{ .value }}", and 
"{{- end }}".
   ```suggestion
         {{- contains .values }}
         - id: {{ notEmpty .id }}
           value: {{ .value }}
           owner: null
           traceid: null
         - id: {{ notEmpty .id }}
           value: null
           owner: null
           traceid: null
         {{- end}}
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to