hanahmily commented on code in PR #788:
URL:
https://github.com/apache/skywalking-banyandb/pull/788#discussion_r2386441266
##########
banyand/trace/syncer.go:
##########
@@ -189,24 +189,16 @@ func (tst *tsTable) syncSnapshot(curSnapshot *snapshot,
syncCh chan *syncIntrodu
if err != nil {
return err
}
- if len(partsToSync) == 0 && len(sidxPartsToSync) == 0 {
- return nil
- }
- hasSidxParts := false
- for _, sidxParts := range sidxPartsToSync {
- if len(sidxParts) == 0 {
- continue
- }
- hasSidxParts = true
- break
- }
- if len(partsToSync) == 0 && !hasSidxParts {
- return nil
+ for name, sidxParts := range sidxPartsToSync {
+ tst.l.Debug().
Review Comment:
Wrap with "if l:=tst.l.Debug();l.Enabled(){}"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
