wu-sheng commented on code in PR #13539:
URL: https://github.com/apache/skywalking/pull/13539#discussion_r2422859717
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBAlarmQueryDAO.java:
##########
@@ -88,12 +93,35 @@ public void apply(StreamQuery query) {
AlarmRecord alarmRecord = builder.storage2Entity(
new
BanyanDBConverter.StorageToStream(AlarmRecord.INDEX_NAME, rowEntity)
);
- AlarmMessage alarmMessage = buildAlarmMessage(alarmRecord);
+ Long recoveryTime = getAlarmRecoveryTime(alarmRecord.getUuid(),
duration);
+ AlarmMessage alarmMessage = buildAlarmMessage(alarmRecord,
recoveryTime);
Review Comment:
You should at least get the alarm list first. Then use the UUID list to
retrieve the recovery list.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
