Copilot commented on code in PR #13533:
URL: https://github.com/apache/skywalking/pull/13533#discussion_r2394458067
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/manual/spanattach/SpanAttachedEventRecord.java:
##########
@@ -131,6 +133,16 @@ public long getTimestampColumnValue() {
return timestamp;
}
+ @Override
+ public String getMergeSpanIdColumnName() {
+ return ZipkinSpanRecord.SPAN_ID;
Review Comment:
The method returns `ZipkinSpanRecord.SPAN_ID` but this class is not related
to Zipkin spans. It should return the appropriate span ID column name for this
record type or use a constant from the current class.
```suggestion
return TRACE_SPAN_ID;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
