wu-sheng commented on code in PR #13508:
URL: https://github.com/apache/skywalking/pull/13508#discussion_r2367599835
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBLogQueryDAO.java:
##########
@@ -76,9 +77,14 @@ public void apply(StreamQuery query) {
}
if (StringUtil.isNotEmpty(serviceInstanceId)) {
+ IDManager.ServiceInstanceID.InstanceIDDefinition
instanceIDDefinition = IDManager.ServiceInstanceID.analysisId(
+ serviceInstanceId);
Review Comment:
We could only set service by instance ID decode when service id absent.
##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBLogQueryDAO.java:
##########
@@ -76,9 +77,14 @@ public void apply(StreamQuery query) {
}
if (StringUtil.isNotEmpty(serviceInstanceId)) {
+ IDManager.ServiceInstanceID.InstanceIDDefinition
instanceIDDefinition = IDManager.ServiceInstanceID.analysisId(
+ serviceInstanceId);
Review Comment:
Because this setting could override wrong service ID, returning logs in that
case is a bug.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
