wankai123 commented on code in PR #100:
URL:
https://github.com/apache/skywalking-banyandb-java-client/pull/100#discussion_r2386530221
##########
src/main/java/org/apache/skywalking/banyandb/v1/client/TraceQueryResponse.java:
##########
@@ -27,9 +27,11 @@
*/
public class TraceQueryResponse {
private final BanyandbTrace.QueryResponse response;
+ private final Trace trace;
TraceQueryResponse(BanyandbTrace.QueryResponse response) {
this.response = response;
+ this.trace = Trace.convertFromProto(response.getTraceQueryResult());
Review Comment:
```
public org.apache.skywalking.banyandb.common.v1.BanyandbCommon.Trace
getTraceQueryResult() {
return traceQueryResult_ == null ?
org.apache.skywalking.banyandb.common.v1.BanyandbCommon.Trace.getDefaultInstance()
: traceQueryResult_;
}
```
won't be null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
