wu-sheng commented on code in PR #13543:
URL: https://github.com/apache/skywalking/pull/13543#discussion_r2428963195
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/analysis/worker/MetricsPersistentWorker.java:
##########
@@ -292,6 +293,9 @@ private void prepareFlushDataToStorage(List<Metrics>
metricsList,
}
private void nextWorker(Metrics metrics) {
+ if (metrics instanceof Meter) {
+ ((Meter) metrics).initMeta(model.getName(), model.getScopeId());
+ }
Review Comment:
Recommend making `RemoteHandleWorker handleWorker` to provide an instance
creator, and support OAL(new Object) and MAL(createNew) ways to initialize the
object correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
