wu-sheng commented on code in PR #13502: URL: https://github.com/apache/skywalking/pull/13502#discussion_r2461070505
########## apm-protocol/apm-network/src/main/java/org/apache/skywalking/oap/server/network/trace/component/command/PprofTaskCommand.java: ########## @@ -0,0 +1,101 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ + +package org.apache.skywalking.oap.server.network.trace.component.command; + +import org.apache.skywalking.apm.network.common.v3.Command; +import org.apache.skywalking.apm.network.common.v3.KeyStringValuePair; +import java.util.List; +import lombok.Getter; + +@Getter +public class PprofTaskCommand extends BaseCommand implements Serializable, Deserializable<PprofTaskCommand> { + public static final Deserializable<PprofTaskCommand> DESERIALIZER = new PprofTaskCommand("", "", "", 0, 0, 0); + public static final String NAME = "PprofTaskQuery"; + /** + * pprof taskId + */ + private String taskId; + // Type of profiling (CPU/Heap/Block/Mutex/Goroutine/Threadcreate/Allocs) Review Comment: The comment format is not consistent, please fix this. ########## docs/en/changes/changes.md: ########## @@ -53,6 +53,7 @@ * Self Observability: add `metrics_aggregation_queue_used_percentage` and `metrics_persistent_collection_cached_size` metrics for the OAP server. * Optimize metrics aggregate/persistent worker: separate `OAL` and `MAL` workers and consume pools. The dataflow signal drives the new MAL consumer, the following table shows the pool sizeļ¼driven mode and queue size for each worker. +* Support the go agent(0.7.0 release) bundled pprof profiling feature. Review Comment: You injected the change logs into a wrong place move it to the last line of oap changes section. ########## docs/en/concepts-and-designs/profiling.md: ########## @@ -47,6 +47,20 @@ Async Profiler can trace the following kinds of events: Only Java agent support this. +### Go App Profiling + +Go App Profiling uses the [Pprof](https://github.com/google/pprof) for sampling. Review Comment: ```suggestion Go App Profiling uses the [pprof](https://github.com/google/pprof) for sampling. ``` ########## docs/en/setup/backend/backend-go-app-profiling.md: ########## @@ -0,0 +1,107 @@ +# Go App Profiling + +Go App Profiling uses the pprof for sampling + +pprof is bound within the auto-instrument agent and corresponds to [In-Process Profiling](../../concepts-and-designs/profiling.md#in-process-profiling). Review Comment: ```suggestion pprof is bundled within the auto-instrument agent and corresponds to [In-Process Profiling](../../concepts-and-designs/profiling.md#in-process-profiling). ``` typo? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
