wu-sheng commented on code in PR #13524:
URL: https://github.com/apache/skywalking/pull/13524#discussion_r2464170617
##########
oap-server/server-receiver-plugin/skywalking-profile-receiver-plugin/pom.xml:
##########
@@ -33,5 +33,27 @@
<artifactId>skywalking-sharing-server-plugin</artifactId>
<version>${project.version}</version>
</dependency>
+ <!-- Protobuf runtime for generated classes in this module -->
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>${com.google.protobuf.protoc.version}</version>
Review Comment:
Version should have been managed by bom. you don't need version here.
##########
oap-server/server-receiver-plugin/skywalking-profile-receiver-plugin/pom.xml:
##########
@@ -33,5 +33,27 @@
<artifactId>skywalking-sharing-server-plugin</artifactId>
<version>${project.version}</version>
</dependency>
+ <!-- Protobuf runtime for generated classes in this module -->
+ <dependency>
+ <groupId>com.google.protobuf</groupId>
+ <artifactId>protobuf-java</artifactId>
+ <version>${com.google.protobuf.protoc.version}</version>
+ </dependency>
+ <!-- Use centralized pprof parser -->
+ <dependency>
+ <groupId>org.apache.skywalking</groupId>
+ <artifactId>library-pprof-parser</artifactId>
+ <version>${project.version}</version>
+ </dependency>
</dependencies>
+
+ <build>
+ <extensions>
+ <extension>
+ <groupId>kr.motd.maven</groupId>
+ <artifactId>os-maven-plugin</artifactId>
+ <version>${os-maven-plugin.version}</version>
+ </extension>
+ </extensions>
Review Comment:
What is this about?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
