wu-sheng commented on code in PR #13524:
URL: https://github.com/apache/skywalking/pull/13524#discussion_r2480349264
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/trace/ProfileThreadSnapshotRecord.java:
##########
@@ -69,6 +70,10 @@ public class ProfileThreadSnapshotRecord extends Record {
private int sequence;
@Column(name = STACK_BINARY)
private byte[] stackBinary;
+ @ElasticSearch.EnableDocValues
+ @Column(name = LANGUAGE_TYPE)
+ @BanyanDB.NoIndexing
+ private ProfileLanguageType language = ProfileLanguageType.JAVA;
Review Comment:
Is this field used as query condition? Why BanyanDB no indexing, but elastic
requires EnableDocValues?
I feel this is not a condition.
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/trace/analyze/ProfileAnalyzer.java:
##########
@@ -115,8 +185,15 @@ protected SequenceSearch getAllSequenceRange(String
segmentId, long start, long
int minSequence =
getProfileThreadSnapshotQueryDAO().queryMinSequence(segmentId, start, end);
int maxSequence =
getProfileThreadSnapshotQueryDAO().queryMaxSequence(segmentId, start, end) + 1;
+ if (LOGGER.isInfoEnabled()) {
+ LOGGER.info("Profile analyze sequence window: segmentId={},
start={}, end={}, minSeq={}, maxSeq(exclusive)={}",
Review Comment:
Why info? This seems a debug log.
##########
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/profiling/trace/analyze/ProfileAnalyzer.java:
##########
@@ -115,8 +185,15 @@ protected SequenceSearch getAllSequenceRange(String
segmentId, long start, long
int minSequence =
getProfileThreadSnapshotQueryDAO().queryMinSequence(segmentId, start, end);
int maxSequence =
getProfileThreadSnapshotQueryDAO().queryMaxSequence(segmentId, start, end) + 1;
+ if (LOGGER.isInfoEnabled()) {
+ LOGGER.info("Profile analyze sequence window: segmentId={},
start={}, end={}, minSeq={}, maxSeq(exclusive)={}",
+ segmentId, start, end, minSequence, maxSequence);
+ }
+
// data not found
if (maxSequence <= 0) {
+ LOGGER.info("Profile analyze not found any sequence in window:
segmentId={}, start={}, end={}",
Review Comment:
Why this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
