wu-sheng commented on code in PR #13539: URL: https://github.com/apache/skywalking/pull/13539#discussion_r2508408117
########## docs/en/setup/backend/backend-alarm.md: ########## @@ -39,6 +39,9 @@ The metrics names in the expression could be found in the [list of all potential If the hook name is not specified, the global hook will be used. - **Silence period**. After the alarm is triggered at Time-N (TN), there will be silence during the **TN -> TN + period**. By default, it works in the same manner as **period**. The same Alarm (having the same ID in the same metrics name) may only be triggered once within a period. +- **Recovery observation period**. Defines the number of consecutive periods that the alarm condition must remain false before the alarm is considered recovered. When the alarm condition becomes false, the system enters an observation period. If the condition remains false for the specified number of periods, a recovery notification is sent. If the condition becomes true again during the observation period, the alarm returns to the FIRING state. +The default value is 0, which means immediate recovery notification when the condition becomes false. Review Comment: About the default value, we could change the default rules into 0, and are considered as immediately recovery. But for ppl don't have this config(previous versions' users), we are better to support `-1` as default value for config absent, which could provide a more consistent behaviour. After all, you will send new notifications. The old confiiguation files don't have `recovery-text-template` or relative url, you should take care of them as normal cases. Otherwise, they are going to fail to boot and upgrade, then have to change all rules manually. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
