GuiSong01 commented on PR #780:
URL: https://github.com/apache/skywalking-java/pull/780#issuecomment-3536511540

   > To add kafka new client version support, you should add new version into 
test scenarios.
   > 
   > 
https://github.com/apache/skywalking-java/blob/main/test/plugin/scenarios/kafka-scenario/support-version.list#L11
   > 
   > As we have 3.7.1, you should add newer versions.
   
   I have not modified the kafka-client plugin, so there is no need to add new 
test scenarios. This PR enhances the spring-kafka plugin by adding support for 
spring-kafka 3.1.0+ versions. The reason is that spring-kafka 3.1.0+ introduces 
an internal class named ExtendedKafkaConsumer in DefaultKafkaConsumerFactory, 
which caused the original spring-kafka 2.x version plugin to become ineffective.
   
   In spring-kafka 2.x, span injection was implemented by intercepting the 
class org.apache.kafka.clients.consumer.KafkaConsumer in the kafka-plugin. 
However, in spring-kafka 3.1.0+, the consumer class has been replaced by 
ExtendedKafkaConsumer.
   
   This change necessitates the enhancement to ensure compatibility with the 
newer versions of spring-kafka.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to