XL-Zhao-23 commented on code in PR #252:
URL: https://github.com/apache/skywalking-eyes/pull/252#discussion_r2554062560
##########
pkg/deps/npm.go:
##########
@@ -87,6 +129,8 @@ func (resolver *NpmResolver) Resolve(pkgFile string, config
*ConfigDeps, report
for _, pkg := range pkgs {
if result := resolver.ResolvePackageLicense(pkg.Name, pkg.Path,
config); result.LicenseSpdxID != "" {
report.Resolve(result)
+ } else if result.SkippedReason != "" {
+ logger.Log.Warnf("Skipping cross-platform package %s
(not for current platform %s)", pkg.Name, runtime.GOOS)
Review Comment:
Reusing the skip logic would introduce additional issues, so we only log a
warning message instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
