wu-sheng commented on code in PR #863:
URL:
https://github.com/apache/skywalking-banyandb/pull/863#discussion_r2564781200
##########
api/proto/banyandb/measure/v1/write.proto:
##########
@@ -42,11 +58,13 @@ message DataPointValue {
// WriteRequest is the request contract for write
message WriteRequest {
// the metadata is required.
- common.v1.Metadata metadata = 1 [(validate.rules).message.required = true];
+ common.v1.Metadata metadata = 1;
// the data_point is required.
DataPointValue data_point = 2 [(validate.rules).message.required = true];
// the message_id is required.
uint64 message_id = 3 [(validate.rules).uint64.gt = 0];
+ // the data point specification.
+ DataPointSpec data_point_spec = 4;
Review Comment:
```suggestion
// the data point specification.
// If this is not set with the indicated metadata, use the schema
definitions.
// If this is not set, use the existing spec declaration from previous
write requests in the current gRPC stream.
DataPointSpec data_point_spec = 4;
```
##########
api/proto/banyandb/measure/v1/write.proto:
##########
@@ -42,11 +58,13 @@ message DataPointValue {
// WriteRequest is the request contract for write
message WriteRequest {
// the metadata is required.
- common.v1.Metadata metadata = 1 [(validate.rules).message.required = true];
+ common.v1.Metadata metadata = 1;
Review Comment:
// Metadata is only required for the first write request of the gRPC stream
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
