Copilot commented on code in PR #13598:
URL: https://github.com/apache/skywalking/pull/13598#discussion_r2587140587
##########
test/e2e-v2/cases/nginx/expected/metrics-has-value-label-percentile-service_instance_id.yml:
##########
@@ -21,14 +21,14 @@ results:
labels:
{{- contains .metric.labels }}
- key: p
- value: {{ .value }}
+ value: {{ notEmpty .value }}
- key: service_instance_id
value: {{ .value }}
Review Comment:
Inconsistency in applying the `notEmpty` validation. Line 26 still uses `{{
.value }}` instead of `{{ notEmpty .value }}` for the `service_instance_id`
label value. This should be changed to `{{ notEmpty .value }}` to be consistent
with the fix being applied throughout this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
