mrproliu commented on code in PR #920:
URL:
https://github.com/apache/skywalking-banyandb/pull/920#discussion_r2659314496
##########
banyand/metadata/client.go:
##########
@@ -96,13 +108,35 @@ func (s *clientService) FlagSet() *run.FlagSet {
fs.StringVar(&s.etcdTLSKeyFile, flagEtcdTLSKeyFile, "", "Private key
for the etcd client certificate.")
fs.DurationVar(&s.registryTimeout, "node-registry-timeout",
2*time.Minute, "The timeout for the node registry")
fs.DurationVar(&s.etcdFullSyncInterval, "etcd-full-sync-interval",
30*time.Minute, "The interval for full sync etcd")
+
+ // DNS-based node discovery configuration
+ fs.BoolVar(&s.dnsRegistryEnabled, "node-registry-dns-enabled", false,
+ "Is DNS registry enabled")
+ fs.StringSliceVar(&s.dnsSRVAddresses,
"node-registry-dns-srv-addresses", []string{},
+ "DNS SRV addresses for node discovery (e.g.,
_grpc._tcp.banyandb.svc.cluster.local)")
Review Comment:
It should be kept, because the port name will be defined in the Kubernetes
service.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
