mrproliu commented on code in PR #928:
URL:
https://github.com/apache/skywalking-banyandb/pull/928#discussion_r2671460115
##########
banyand/metadata/client.go:
##########
@@ -133,13 +139,19 @@ func (s *clientService) FlagSet() *run.FlagSet {
"Enable TLS for DNS discovery gRPC connections")
fs.StringSliceVar(&s.dnsCACertPaths, "node-discovery-dns-ca-certs",
[]string{},
"Comma-separated list of CA certificate files to verify DNS
discovered nodes (one per SRV address, in same order)")
+ fs.StringVar(&s.filePath, "node-discovery-file-path", "",
+ "File path for static node configuration (file mode only)")
+ fs.DurationVar(&s.fileFetchInterval,
"node-discovery-file-fetch-interval", 20*time.Second,
+ "Fetch file interval for nodes in file discovery mode")
Review Comment:
Should be changed to this one: "Interval to poll the discovery file and
retry failed nodes in file discovery mode".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
